Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check on CI to compare more files #147

Closed
wants to merge 13 commits into from
Closed

Add check on CI to compare more files #147

wants to merge 13 commits into from

Conversation

fcollonval
Copy link
Member

Fixes #120

This approach uses the suggestion of applying the upgrade script

@fcollonval
Copy link
Member Author

Should we copy the following files in the upgrade script:

      - name: Check config files
        if: steps.filter.outputs.extension == 'true'
        run: |
          diff basics/hello-world/tsconfig.json ${EXAMPLE_FOLDER}/tsconfig.json
          diff basics/hello-world/.eslintignore ${EXAMPLE_FOLDER}/.eslintignore
          diff basics/hello-world/.eslintrc.js ${EXAMPLE_FOLDER}/.eslintrc.js
          diff basics/hello-world/.gitignore ${EXAMPLE_FOLDER}/.gitignore

so that this check can be removed?

@fcollonval
Copy link
Member Author

This is ready for review

@jtpio
Copy link
Member

jtpio commented Feb 18, 2021

Should we copy the following files in the upgrade script:

Would that affect how the upgrade is script is run locally? For example would we need to set the EXAMPLE_FOLDER variable?

Maybe it's fine to keep them separate for now.

@fcollonval
Copy link
Member Author

Closing as the structure evolved quite a lot

@fcollonval fcollonval closed this Jun 14, 2023
@fcollonval fcollonval deleted the fcollonval/issue120 branch June 14, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check on CI to compare more files
2 participants
@fcollonval @jtpio