Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jsonschema and jupyter_events dependencies #185

Closed
bollwyvl opened this issue Aug 11, 2023 · 1 comment · Fixed by #186
Closed

Updating jsonschema and jupyter_events dependencies #185

bollwyvl opened this issue Aug 11, 2023 · 1 comment · Fixed by #186
Labels
enhancement New feature or request

Comments

@bollwyvl
Copy link

bollwyvl commented Aug 11, 2023

Problem

The current pin to jsonschema <4.18.0 makes this package incompatible with jupyter_events >=0.7.0, and the 0.6.x line is unlikely to get further updates barring severe security issues, nor is the 0.7.0 line likely to backpedal on its upstream deps.

As jupyter_events is a hard dependency of jupyter_server, this will become a larger issue in the future.

Proposed Solution

Either:

  • raise bottom pins to:
    • jsonschema >=4.18.0
    • jupyter_events >=0.7.0
  • determine how to support the entire range (significantly harder)

And then:

  • declare minimum versions, removing top pins
  • test against the minimum declared versions (at least in CI)

Additional context

c/f conda-forge/jupyter-collaboration-feedstock#2 (comment)

@bollwyvl bollwyvl added the enhancement New feature or request label Aug 11, 2023
@welcome
Copy link

welcome bot commented Aug 11, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant