Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser check is not failing when it should #8709

Closed
blink1073 opened this issue Jul 22, 2020 · 0 comments · Fixed by #8717
Closed

Browser check is not failing when it should #8709

blink1073 opened this issue Jul 22, 2020 · 0 comments · Fixed by #8717
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Milestone
3.0

Comments

@blink1073
Copy link
Contributor

blink1073 commented Jul 22, 2020 •
edited
Loading

I noticed while working on jupyterlab/jupyterlab-module-federation#22 that despite the chrome test failing, the job was succeeding. Pinning to 2.1.5 allowed the job to properly fail.
@blink1073 blink1073 added this to the 3.0 milestone Jul 22, 2020
@blink1073 blink1073 mentioned this issue Jul 26, 2020
Merged
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Handle errors in async browser_check blink1073/jupyterlab
1 participant
@blink1073