-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot override settings by null
value
#278
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
Hi @aidy1991, would you open to submitting a PR to |
Hi blink1073, thank you for your reply! jupyter_server's On the other hand, jupyterlab_server changed its usage of |
Ah, I see. A PR here would be welcome then. 😄 |
Description
Our application uses jupyterlab's settings override feature to change the settings of some extensions.
However, due to an upgrade of jupyterlab_server (v2.5.2 => v2.12.0), the settings are no longer overridden.
From my investigation, settings are not overridden if the value is
null
, as in{ "format": null }
. This is probably becauserecursive_update
used in the following location ignores properties with the value None.jupyterlab_server/jupyterlab_server/settings_utils.py
Line 297 in d5c07d6
Reproduce
I faced this problem when overriding the jupyter-archive configuration. Therefore, below I describe how to reproduce the problem in the case of jupyter-archive. However, the same should be true for other settings as well.
jupyter-archive
extensionformat
iszip
onAdvanced Settings Editor
sys.prefix>/local/share/jupyter/lab/settings/overrides.json
and see below for the contents of this fileformat
is not overridden(5. If you set non-null value like
tgz
, it works well)Expected behavior
In previous versions of jupyterlab_server, setting values could be overridden with
null
. Newer versions should be able to do the same, I think.Context
The text was updated successfully, but these errors were encountered: