Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom commit message when running a PR script #8

Closed
jtpio opened this issue Nov 17, 2021 · 1 comment · Fixed by #9
Closed

Custom commit message when running a PR script #8

jtpio opened this issue Nov 17, 2021 · 1 comment · Fixed by #9
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Nov 17, 2021

Problem

Right now the PR script workflows creates a new commit with "Run maintainer script" as the message.

It would be nice to be able to pass a custom commit message as part of the workflow inputs. For example "Lint" when running a lint script.

Proposed Solution

Probably we can pass the input down to the script, so it can be picked up here:

run(f"git commit -a -m 'Run maintainer script' -m 'by {maintainer}' -m '{json.dumps(script)}'")

Additional context

Example commit currently generated: jupyterlab/jupyterlab@6971c03

@jtpio jtpio added the enhancement New feature or request label Nov 17, 2021
@welcome
Copy link

welcome bot commented Nov 17, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant