From 75a57edadc9213bf404c67ff4949217da5b4d0ff Mon Sep 17 00:00:00 2001 From: Ramkumar Ramachandra Date: Fri, 13 Sep 2024 20:08:11 +0100 Subject: [PATCH] VPlan/Builder: inline VPBuilder::createICmp (NFC) (#105650) Inline VPBuilder::createICmp in the header, in line with the other VPBuilder functions. --- llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h | 7 ++++++- llvm/lib/Transforms/Vectorize/LoopVectorize.cpp | 8 -------- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h b/llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h index 322b431e073d40..9979081b6decc9 100644 --- a/llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h +++ b/llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h @@ -203,7 +203,12 @@ class VPBuilder { /// and \p B. /// TODO: add createFCmp when needed. VPValue *createICmp(CmpInst::Predicate Pred, VPValue *A, VPValue *B, - DebugLoc DL = {}, const Twine &Name = ""); + DebugLoc DL = {}, const Twine &Name = "") { + assert(Pred >= CmpInst::FIRST_ICMP_PREDICATE && + Pred <= CmpInst::LAST_ICMP_PREDICATE && "invalid predicate"); + return tryInsertInstruction( + new VPInstruction(Instruction::ICmp, Pred, A, B, DL, Name)); + } //===--------------------------------------------------------------------===// // RAII helpers. diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp index 1f13253216962e..3a313a96be7e85 100644 --- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp +++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp @@ -6939,14 +6939,6 @@ void LoopVectorizationCostModel::collectInLoopReductions() { } } -VPValue *VPBuilder::createICmp(CmpInst::Predicate Pred, VPValue *A, VPValue *B, - DebugLoc DL, const Twine &Name) { - assert(Pred >= CmpInst::FIRST_ICMP_PREDICATE && - Pred <= CmpInst::LAST_ICMP_PREDICATE && "invalid predicate"); - return tryInsertInstruction( - new VPInstruction(Instruction::ICmp, Pred, A, B, DL, Name)); -} - // This function will select a scalable VF if the target supports scalable // vectors and a fixed one otherwise. // TODO: we could return a pair of values that specify the max VF and