Skip to content
This repository has been archived by the owner on Feb 2, 2019. It is now read-only.

Fix inputs provisionned after init #40

Closed
wants to merge 2 commits into from

Conversation

azorgh
Copy link

@azorgh azorgh commented Feb 2, 2016

Hi,

Referred to Issue #39 .

I changed the condition to check if value is empty or not.

@ollwenjones
Copy link
Collaborator

These tests are failing because the browsers aren't starting...

@justindujardin
Copy link
Owner

Please rebase on the latest master to fix the travis build issue for PRs.

@justindujardin
Copy link
Owner

@pallmallshow I'd like to have a test to cover how this was failing before and see it pass with your changes. Is this something you can do? There is an input test already, so adding another should be a breeze. See: https://github.com/justindujardin/ng2-material/blob/master/test/components/input/input_spec.ts#L73

@sylvaindumont
Copy link
Contributor

The fix work well with data coming from http, but 'undefined' is written in all blanks input.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants