Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/fix 24-bit and 32-bit encoding #9

Open
justinruggles opened this issue May 26, 2010 · 6 comments
Open

test/fix 24-bit and 32-bit encoding #9

justinruggles opened this issue May 26, 2010 · 6 comments
Labels

Comments

@justinruggles
Copy link
Owner

Need to test 32-bit encoding.
Need to fix 24-bit encoding.
Will post test details later...

@justinruggles
Copy link
Owner Author

24-bit files are tagged as 32-bit, so they don't decode to match original.
CRC is not calculated correctly for 24-bit files.

@justinruggles
Copy link
Owner Author

Well, this seems more complicated than I thought. I applied what I thought was a fix to the 24-bit issue but now it gives noise when decoded. Still working on a solution.

@justinruggles
Copy link
Owner Author

ok, I'm pretty sure this is fixed now. We just need to do some extensive testing.

@thiloborgmann
Copy link
Collaborator

Oh I've not seen these comments before...
I think I correctly encoded with 24 bit yesterday so I think this is fixed, too.
I will add 24 bit files into my conformance test suite and report back then.

@thiloborgmann
Copy link
Collaborator

I successfully tested encoding using the 24b wave file included in the conformance files via our .als muxer. Ignoring the original wav header, the restored samples are identical.

p.s. valid reconstruction tested for compression-levels 1-3

@justinruggles
Copy link
Owner Author

Great. I'm pretty sure 32-bit is fine, but we need to test this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants