Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit tests #30

Closed
3 tasks done
jvdd opened this issue Feb 26, 2023 · 0 comments · Fixed by #31
Closed
3 tasks done

Improve unit tests #30

jvdd opened this issue Feb 26, 2023 · 0 comments · Fixed by #31

Comments

@jvdd
Copy link
Owner

jvdd commented Feb 26, 2023 •
edited
Loading

Currently all unit tests are literally between the code - making the code look much more intimidating than it is.

Ideally we place the tests in some other place:

  • look into Rust best practices for unit testing
  • move the tests to a better place

(optinally)

  • parameterize the tests using rstest and rstest_reuse

Credits @varon, see #21 (review)
This was referenced Feb 26, 2023
Merged
Merged
@jvdd jvdd closed this as completed in #31 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻️ parameterize tests jvdd/argminmax
1 participant
@jvdd