Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Sanitize possible html-breaking code and output before passing through pygments #12

Open
hdamron17 opened this issue May 16, 2018 · 3 comments

Comments

@hdamron17
Copy link
Collaborator

No description provided.

@jyn514
Copy link
Owner

jyn514 commented May 19, 2018

I think we should do this after pygments, right? since pygments outputs html, it probably does most of the escaping for us. We should check the docs on that.

Also, plain text is rendered as HTML, which messes up formatting. We should fix that. This was a seperate issue caused by the file extension not being recognized

@hdamron17
Copy link
Collaborator Author

It would need to be before pygments since the pygments output we want to be real html. But escaping before pygments may mess with the pygments parser so that may cause an issue. There is also an option possibly that there is a flask plugin to do pygments highlighting for us. It may help with this issue but it also ties us down to pygments more than we are currently.

@jyn514
Copy link
Owner

jyn514 commented May 19, 2018

Can you give an example of this issue? I haven't seen this happen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants