Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator [N] [CI] oracle-database-operator (v1.1.0) #5045

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

psilberk
Copy link

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@github-actions github-actions bot changed the title Adding Oracle Database Operator v1.1.0 operator [N] oracle-database-operator (v1.1.0) Sep 19, 2024
Copy link
Contributor

Dear @psilberk,
Some errors and/or warnings were found while doing the check of your operator (oracle-database-operator/v1.1.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
🐛 Value : (oracle-database-operator.v0.0.1) csv.Spec.Icon png does not have a valid mediatype
⚠️ Value database.oracle.com/v1alpha1, Kind=DbcsSystem: provided API should have an example annotation
⚠️ Value : (oracle-database-operator.v0.0.1) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value oracle-database-operator.v0.0.1: owned CRD "dbcssystems.database.oracle.com" has an empty description

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Dear @psilberk,
Some errors and/or warnings were found while doing the check of your operator (oracle-database-operator/v1.1.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
🐛 Value : (oracle-database-operator.v1.1.0) csv.Spec.Icon png does not have a valid mediatype
⚠️ Value database.oracle.com/v1alpha1, Kind=DbcsSystem: provided API should have an example annotation
⚠️ Value : (oracle-database-operator.v1.1.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value oracle-database-operator.v1.1.0: owned CRD "dbcssystems.database.oracle.com" has an empty description

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Dear @psilberk,
Some errors and/or warnings were found while doing the check of your operator (oracle-database-operator/v1.1.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value database.oracle.com/v1alpha1, Kind=DbcsSystem: provided API should have an example annotation
⚠️ Value : (oracle-database-operator.v1.1.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value oracle-database-operator.v1.1.0: owned CRD "dbcssystems.database.oracle.com" has an empty description

2 similar comments
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Dear @psilberk,
Some errors and/or warnings were found while doing the check of your operator (oracle-database-operator/v1.1.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value database.oracle.com/v1alpha1, Kind=DbcsSystem: provided API should have an example annotation
⚠️ Value : (oracle-database-operator.v1.1.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value oracle-database-operator.v1.1.0: owned CRD "dbcssystems.database.oracle.com" has an empty description

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Dear @psilberk,
Some errors and/or warnings were found while doing the check of your operator (oracle-database-operator/v1.1.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value database.oracle.com/v1alpha1, Kind=DbcsSystem: provided API should have an example annotation
⚠️ Value : (oracle-database-operator.v1.1.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value oracle-database-operator.v1.1.0: owned CRD "dbcssystems.database.oracle.com" has an empty description

@psilberk
Copy link
Author

psilberk commented Oct 4, 2024

@haripate @tomasbakk I've been trying to create this pull request for our Operator (Oracle) but it's becoming impossible to walk-around some checks. Can I get some support from you? Thanks

@haripate
Copy link
Collaborator

haripate commented Oct 4, 2024

@psilberk I will take a look into it.

@haripate
Copy link
Collaborator

haripate commented Oct 4, 2024

There are couple of issues I found:

  1. The value of containerImage and image field should be same. This means you need to use the same image in the container as you mentioned in containerImage field.
  2. The ci.yaml file is missing in the submitted changes. Please review this document for reference.

Let me know if you still face any issues.

@psilberk
Copy link
Author

psilberk commented Oct 4, 2024

Thanks @haripate , I'll review this.
With respect to the commits signoff, I've been trying the latest commits with --signoff and still have the error. Any recommendation to solve this?

@haripate
Copy link
Collaborator

haripate commented Oct 4, 2024

Thanks @haripate , I'll review this. With respect to the commits signoff, I've been trying the latest commits with --signoff and still have the error. Any recommendation to solve this?

@psilberk
Looks like few previous commits are missing sign-offs.
Please follow the below steps.

  1. In your local branch, run: git rebase HEAD~7 --signoff
  2. Force push your changes to overwrite the branch: git push --force-with-lease origin <your_branch>

Signed-off-by: pablo_silberkasten <pablo.silberkasten@oracle.com>
…-operatorhub#3)

Signed-off-by: pablo_silberkasten <pablo.silberkasten@oracle.com>
…-operatorhub#3)

Signed-off-by: pablo_silberkasten <pablo.silberkasten@oracle.com>
Signed-off-by: pablo_silberkasten <pablo.silberkasten@oracle.com>
Signed-off-by: pablo_silberkasten <pablo.silberkasten@oracle.com>
Adding Oracle Database Operator

Signed-off-by: pablo_silberkasten <pablo.silberkasten@oracle.com>
Signed-off-by: pablo_silberkasten <pablo.silberkasten@oracle.com>
@github-actions github-actions bot changed the title operator [N] oracle-database-operator (v1.1.0) operator [N] [CI] oracle-database-operator (v1.1.0) Oct 5, 2024
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Dear @psilberk,
Some errors and/or warnings were found while doing the check of your operator (oracle-database-operator/v1.1.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value database.oracle.com/v1alpha1, Kind=DbcsSystem: provided API should have an example annotation
⚠️ Value : (oracle-database-operator.v1.1.0) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value oracle-database-operator.v1.1.0: owned CRD "dbcssystems.database.oracle.com" has an empty description

@psilberk
Copy link
Author

psilberk commented Oct 5, 2024

Thanks @haripate , but it looks like the signoff didn't work and there's another error (maybe because the signoff didn't work?): fatal: [localhost]: FAILED! => changed=false
msg: Operator was not found among packagemanifests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants