Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push mainfest on merge to master is failing #470

Closed
adrianchiris opened this issue Feb 26, 2023 · 2 comments
Closed

Push mainfest on merge to master is failing #470

adrianchiris opened this issue Feb 26, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@adrianchiris
Copy link
Contributor

What happened?

Push manifest Job is failing:
https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/4274943872/jobs/7442033582

we should fix it.
@adrianchiris adrianchiris added the bug Something isn't working label Feb 26, 2023
@adrianchiris adrianchiris mentioned this issue Feb 27, 2023
Merged
@adrianchiris
Copy link
Contributor Author

After additional investigation it seems that docker build push action builds and pushes manifest (with single arch) when platform field is specified.

then the manifest job fails since

  1. it tries to pull manifest instead of the container image itself, fails on arm64 as the job is running on amd64
  2. even if we use the --platform flag to pull image, it would still fail on mainfest creation, as it pulls a manifest and not a container image.

@adrianchiris
Copy link
Contributor Author

fixed by #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrianchiris