-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both gitignore and minimatch ignore type #1
Comments
Maybe |
I'd be thinking to deprecate this module for globby supports .gitignore in the latest version. |
Well actually I was looking at Currently Performances could maybe be improved by doing all that at once (like avoid to retrieve files to filter them after) |
Yep, that is the only reason to use That is a good question. Let me explain that. But actually, the behavior of gitignore is differrent from and even conflicting with
while So, IMO it is better not to use |
Maybe we'd move this topic to sindresorhus/globby#50 |
Close for now |
It seems this library replace the
node-glob
ignore
option with one that is compatible with the.gitignore
format, but we loose the ability to use regularminimatch
ignore.Would it be possible to have instead the options:
ignore
: works like the regularnode-glob
ignore
optionsgitignore
: works withgitignore
formatThat would to support cases in which we have both a
.gitignore
file andminimatch
pattern to ignore.The text was updated successfully, but these errors were encountered: