Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julie is creating odd Role Binding for Resource Type Connector #402

Closed
Fobhep opened this issue Nov 17, 2021 · 1 comment · Fixed by #405
Closed

Julie is creating odd Role Binding for Resource Type Connector #402

Fobhep opened this issue Nov 17, 2021 · 1 comment · Fixed by #405
Labels
bug Something isn't working

Comments

@Fobhep
Copy link
Contributor

Fobhep commented Nov 17, 2021

This is kind of analog to #399

I am creating custom roles:

roles:
  - name: "creditcardmockgenread"
    acls:
      - resourceType: "Connector"
        resourceName: "creditcard-mockgen"
        patternType: "LITERAL"
        role: "DeveloperRead"
        host: "*"
  - name: "creditcardmockgenwrite"
    acls:
      - resourceType: "Connector"
        resourceName: "creditcard-mockgen"
        patternType: "LITERAL"
        role: "DeveloperWrite"
        host: "*"

And use those in my descriptor

---
context: context
source: test
projects:
  - name: "foo"
    creditcardmockgenread:
      -
        principal: User:greta
    creditcardmockgenwrite:
      -
        principal: User:greta

That creates:

  Principal  |      Role       | ResourceType |               Name               | PatternType  
-------------+-----------------+--------------+----------------------------------+--------------
User:greta | DeveloperRead   | Connector      | Connector:creditcard-mockgen | LITERAL      
User:greta | DeveloperWrite   | Connector      | Connector:creditcard-mockgen | LITERAL   

Expected behavior
This should be created:

  Principal  |      Role       | ResourceType |               Name               | PatternType  
-------------+-----------------+--------------+----------------------------------+--------------
User:greta | DeveloperRead   | Connector      | creditcard-mockgen | LITERAL      
User:greta | DeveloperWrite  | Connector     | creditcard-mockgen | LITERAL   
@purbon
Copy link
Collaborator

purbon commented Nov 21, 2021

Thanks for reporting this issue. I add a fix, including regression tests as well. This should be fixed with #405, this is, for now, available in master and in the latest nightly release build from https://github.com/kafka-ops/julie/actions/workflows/nightly-artifacts-build.yml

It will be included in next release, it would be awesome if you can grab from master and let me know here all is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants