Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreading with PointNeighbors.jl and Polyester.jl #110

Closed
kaipartmann opened this issue Jun 21, 2024 · 2 comments
Closed

Multithreading with PointNeighbors.jl and Polyester.jl #110

kaipartmann opened this issue Jun 21, 2024 · 2 comments
Labels
parallelization Related to MPI or threading etc. performance Anything relevant for performance

Comments

@kaipartmann
Copy link
Owner

kaipartmann commented Jun 21, 2024

There are differences in performance (see #107 (comment)) that seem to be related to combining Polyester.@batch and Base.Threads.

PointNeighbors.jl uses Polyester.@batch within the @threaded macro.

With threaded_nhs_update=true and changing all Threads.@threads calls in Peridynamics.jl, the following differences occur for the benchmark in #107 (comment):

# `@threads :static`
#  49.821336 seconds (2.93 M allocations: 3.263 GiB, 0.13% gc time)

# `@threads`
#  27.514394 seconds (2.92 M allocations: 3.262 GiB, 0.39% gc time)

# `Polyester.@batch`
#  11.450976 seconds (2.34 M allocations: 3.199 GiB, 0.49% gc time)

Originally posted by @kaipartmann in #107 (comment)

@kaipartmann kaipartmann added help wanted Extra attention is needed performance Anything relevant for performance labels Jun 21, 2024
@kaipartmann
Copy link
Owner Author

@efaulhaber

@kaipartmann kaipartmann changed the title Multithreading with PointNeighbors.jl and Polyester Multithreading with PointNeighbors.jl and Polyester.jl Jun 21, 2024
@kaipartmann kaipartmann added parallelization Related to MPI or threading etc. and removed help wanted Extra attention is needed labels Jun 21, 2024
@kaipartmann
Copy link
Owner Author

Closed with #153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parallelization Related to MPI or threading etc. performance Anything relevant for performance
Projects
None yet
Development

No branches or pull requests

1 participant