Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check modules for defineMessages imports #163

Conversation

odeniso
Copy link
Contributor

@odeniso odeniso commented Oct 11, 2021

previously only svelte "scripts" were being checked

@kaisermann this is a follow up to #157

@odeniso
Copy link
Contributor Author

odeniso commented Oct 11, 2021

Issue here: #164

@kaisermann
Copy link
Owner

Hey, @odeniso 👋 Thanks for the contribution once again!

@kaisermann kaisermann merged commit ec939ab into kaisermann:main Oct 11, 2021
@kaisermann
Copy link
Owner

Released in v3.3.13 🎉

@odeniso odeniso deleted the check-import-declarations-in-module-scripts branch October 13, 2021 08:32
@odeniso
Copy link
Contributor Author

odeniso commented Oct 13, 2021

@kaisermann I just noticed I accidentally introduced the lock file for the with this PR. Should I remove it and add it to the gitignore?

@kaisermann
Copy link
Owner

Didn't see it! Don't worry, I'll remove it 👌 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants