Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling an object for api.rs? #44

Closed
jeehoonkang opened this issue Sep 1, 2019 · 0 comments · Fixed by #57
Closed

Modeling an object for api.rs? #44

jeehoonkang opened this issue Sep 1, 2019 · 0 comments · Fixed by #57

Comments

@jeehoonkang
Copy link
Member

지금은 api.rs에 C function으로 노출되는 함수에서 바로 logic이 정의되어 있는데 (e.g. api_vm_configure), 이를 (1) object와 (2) object의 member function으로 접근하는 방식으로 바꿀 수 있으면 좋겠습니다.

목적: 지금은 C function이 unsafe여야 하므로, 아무리 refactoring을 해도 unsafe 코드의 양이 줄지 않습니다. 명확히 어느 지점이 unsafe이고 어느 지점이 아닌지 밝히기 위해 위와 같은 refactoring을 제안합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant