Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lfs: stack overflow happens too often on low rustc version #613

Open
travis1829 opened this issue Mar 9, 2022 · 1 comment
Open

Lfs: stack overflow happens too often on low rustc version #613

travis1829 opened this issue Mar 9, 2022 · 1 comment

Comments

@travis1829
Copy link
Collaborator

travis1829 commented Mar 9, 2022 •
edited
Loading

Currently, rv6 is using rustc nightly-2021-06-19, but compared to the latest (tried on 2022-03-09), it seems like usertests is much slower and also causes a lot of stack overflows when testing the lfs on this version.

kerneltrap(): scause 0x000000000000000f
sepc=0x000000008004c5a6 stval=0x0000003fffff6000

Since this is an optimization issue, I think it will be hard to resolve this through changing the code. Instead, it seems like we should upgrade the rustc version someday.
@travis1829 travis1829 mentioned this issue Mar 9, 2022
Merged
@travis1829
Copy link
Collaborator Author

EDIT: It seems like this doesn't happen anymore after fixing a lot of parts. However, note that rv6 is still much slower on low rustc versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@travis1829