fix(ComponentChildMixin): this.nearestOfType() is not reliable in wil…

…lDestroyElement hook Fixes #99
ember-bootstrap · Jun 3, 2016 · 44a9fa0 · 44a9fa0
2 parents 00bfde3 + 47ec98a
commit 44a9fa0
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/addon/mixins/component-child.js b/addon/mixins/component-child.js
@@ -14,11 +14,16 @@ export default Ember.Mixin.create({
     let parent = this.nearestOfType(ComponentParentMixin);
     if (parent) {
       parent.registerChild(this);
+      this.set('_parent', parent);
     }
   }),
 
+  // stores the parent in didInsertElement hook as a work-a-round for
+  // https://github.com/emberjs/ember.js/issues/12080
+  _parent: null,
+
   _willDestroyElement: Ember.on('willDestroyElement', function() {
-    let parent = this.nearestOfType(ComponentParentMixin);
+    let parent = this.nearestOfType(ComponentParentMixin) || this.get('_parent');
     if (parent) {
       parent.removeChild(this);
     }