Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5 attributes support #148

Closed
basz opened this issue Nov 3, 2016 · 0 comments
Closed

html5 attributes support #148

basz opened this issue Nov 3, 2016 · 0 comments

Comments

@basz
Copy link
Contributor

basz commented Nov 3, 2016

{{#bs-button title="Cancel what you are doing..." type="default"}}
    Cancel
{{/bs-button}}

renders as;

<button id="ember1391" type="button" class="ember-view btn btn-default">
    Cancel
</button>

simply adding 'title' to attributeBindings in addons/components/bs-button solves it.

attributeBindings: ['disabled', 'buttonType:type', 'title'],

But there might be more attributes; http://www.quackit.com/html_5/tags/html_5_global_attributes.cfm

Is there a reason these (or a subset of) are not implemented? I can easily create a PR, but I can't do tests and I would like to know if it would considered at all...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant