Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having a ember-cli-sass installed without boostrap-sass breaks build. #322

Closed
AvremelM opened this issue May 10, 2017 · 2 comments
Closed
Assignees

Comments

@AvremelM
Copy link
Contributor

There is no way to not use bootstrapp-sass (or bootstrap-less (via importBootstrapTheme and importBootstrapCSS) if you have a supported preprocessor installed.

Therefore, since I have ember-cli-sass installed (for other things), but am including the boostrap css elsewhere, I get an error when trying to build (index.js:91):

Npm package "bootstrap-sass" is missing, but required for SASS support. Please run ember generate ember-bootstrap to install the missing dependencies!

I tried running ember generate ember-bootstrap --preprocessor=none but all that accomplished was it uninstalling my ember-cli-sass, which wasn't precisely the solution I was looking for.

(For now, I'm working around this by installing ember-boostrap but removing the import from app.scss)

Output from ember bootstrap:info

Npm packages:
ember-bootstrap: ^1.0.0-alpha.12 -> 1.0.0-alpha.12
ember-cli: 2.12.1 -> 2.12.1
bootstrap: ^3.3.7 -> 3.3.7
bootstrap-sass: n/a
ember-cli-sass: ^5.6.0 -> 5.6.0
ember-cli-less: n/a

Bower packages:
bootstrap: n/a
bootstrap-sass: n/a

ember-bootstrap configuration:
importBootstrapTheme: false
importBootstrapCSS: false
bootstrapVersion: 3
importBootstrapFont: true
@srvance
Copy link
Contributor

srvance commented May 15, 2017

It sounds like we should weaken the message to a warning or at least not make it a failing condition.

@srvance srvance self-assigned this May 15, 2017
@simonihmig
Copy link
Contributor

@srvance Warning probably makes sense!

srvance added a commit that referenced this issue May 15, 2017
Change sass preprocessor error to a warning and update the wording.
simonihmig pushed a commit that referenced this issue May 16, 2017
… configurations

* Fixes #322.

Change sass preprocessor error to a warning and update the wording.

* Wording change.

* Similar softening of the error when using less without the right bootstrap dependency.

* Refactor the warning message incantation into a method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants