Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Tooltips #7

Closed
CamonZ opened this issue Jul 5, 2015 · 8 comments
Closed

Feature Request: Tooltips #7

CamonZ opened this issue Jul 5, 2015 · 8 comments
Labels
feature request

Comments

@CamonZ
Copy link

CamonZ commented Jul 5, 2015

Hi, what's the possibility of adding tooltips support, I can contribute a PR for it but I'm wondering what's the best approach to mach the vision you have for the addon.

I was thinking of doing something similar to what was done on the old bootstrap-for-ember code where you have an component which will render all tooltips, then a component for each tooltip and a helper which will bind an element to have tooltips enabled; the positioning for each tooltip will be calculated from the element with the binding. I'll skip the controller and outlets hackery they had if possible.

Do you think this is a viable approach?
@simonihmig
Copy link
Contributor

There is a very simple implementation in the 'tooltip' branch, that relies on the original bootstrap.js. That does not play nice especially with acceptance tests, so I probably won't ever merge that into master.

The solution should be a native solution as you suggest. I looked into https://github.com/yapplabs/ember-wormhole as a way to push UI elements at some other place than they belong to logically (bootstrap.js renders them as childs of <body>).

But besides that I have no architectural pattern layed out already...

@CamonZ
Copy link
Author

CamonZ commented Jul 7, 2015

I'm going to take a look at ember-wormhole and try to have a PR before the end of the week.

@lypanov
Copy link

lypanov commented Dec 1, 2015

Did you have any luck with this @CamonZ?

@ngelx
Copy link

ngelx commented Apr 3, 2016

+1
any way i can help with this?

@PratheepV
Copy link

+1

@simonihmig simonihmig mentioned this issue Jun 8, 2016
Closed
@brmendez
Copy link

+1
Hi Simon, I am all for Bootstraps Popover component. Is this in the making or are there any plans to do this in the next release?

Thank you.

@simonihmig
Copy link
Contributor

After Tabs and Navs have landed in v0.8.0 I will try to tackle this as the next major feature!

@simonihmig
Copy link
Contributor

fyi, v0.11.0 finally adds support for tooltips & popovers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lypanov @CamonZ @ngelx @PratheepV @simonihmig @brmendez