Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings for removed form element arguments disabled and readonly #1077

Merged
merged 1 commit into from
May 16, 2020
Merged

Fix warnings for removed form element arguments disabled and readonly #1077

merged 1 commit into from
May 16, 2020

Conversation

simonihmig
Copy link
Contributor

No description provided.

@simonihmig simonihmig requested a review from jelhan May 13, 2020 12:34
@simonihmig simonihmig added the bug label May 13, 2020
jelhan
jelhan approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Would be awesome if we could set HTML attributes when having dynamic component invocation. Feels like we are hacking around that limitation so much.

@simonihmig simonihmig merged commit f536c1a into master May 16, 2020
@simonihmig simonihmig deleted the fix-warnings branch May 16, 2020 14:50
@simonihmig simonihmig mentioned this pull request May 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelhan jelhan jelhan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonihmig @jelhan