Update API docs for FormElement#value #1108
Conversation
|
lgtm |
There was a problem hiding this comment.
Looks good to me.
I'm only not sure if we should recommend to override default event handler or to add your own. But that's not directly related to this PR. To be honest I'm not even fully sure if <BsForm:: Element {{on "change" this.foo}} /> works and if we consider it public API...
| * | ||
| * ```hbs | ||
| * <form.element @controlType="email" @label="Email" @value={{this.email}} /> | ||
| * ``` | ||
| * | ||
| * Note: you lose the ability to validate this form element by directly binding to its value. It is recommended | ||
| * Note two things: | ||
| * * the binding is uni-directional (DDAU), so you would have to use the `onChange` action to subscribe to changes. |
There was a problem hiding this comment.
Does {{on "change" this.updateMyValue}} work as well? I think / hope so but haven't checked myself. Not sure if we should recommend that one instead of overriding onChange.
There was a problem hiding this comment.
I don't think this can work, as the element that ...attributes is passed to is .form-group IIRC. Which obviously has no change event.
But that's what onChange is explicitly for. When using property it is already wired up to essentially mutate model, but when using @value you would want to use it.
cc @basz