Fix deprecations failing the build

[simonihmig]

• ignore upstream deprecations we cannot influence here (modifier-manager)
• don't setup deprecation tracking for tests that test positional params in our <LinkTo> subclasses, as we have those tests for compatibility with that legacy API (positional params), but can regard that as deprecated from our side as well

[simonihmig]

This is checking hasEmberVersion(3, 10), i.e. guards against Ember <3.10, which we don't support anymore.

[simonihmig]

The diff looks large, but basically I just moved that setupNoDeprecations call from the outer module() to this submodule, thus not applying it to the module testing positional params.

[simonihmig]

Hm, I tested this locally with beta (which is passing now), but apparently canary has a new deprecation added. Will tackle this later...

[lupestro]

While you're at it, do you want to do all the {{#if hasBlock}} to {{#if has-block}} adjustments, with hasBlock also deprecated in beta? (RFC #689). I have seen these deprecations show up in building one or two of my addons, so I did a grep of the whole GIT forest for all my projects, including the node_modules, found the following from ember-bootstrap, and confirmed they're still present in master.

addon\templates\components\bs3\bs-form\element\control\radio.hbs
addon\templates\components\bs3\bs-form\element\control\radio.hbs
addon\templates\components\bs3\bs-form\element\label.hbs
addon\templates\components\bs3\bs-modal\header.hbs
addon\templates\components\bs3\bs-modal\header.hbs
addon\templates\components\bs3\bs-navbar\toggle.hbs
addon\templates\components\bs4\bs-form\element\control\radio.hbs
addon\templates\components\bs4\bs-form\element\label.hbs
addon\templates\components\bs4\bs-modal\header.hbs
addon\templates\components\bs4\bs-modal\header.hbs
addon\templates\components\bs4\bs-navbar\toggle.hbs
addon\templates\components\common\bs-accordion\item.hbs
addon\templates\components\common\bs-form\element.hbs
addon\templates\components\common\bs-modal\footer.hbs
addon\templates\components\common\bs-progress\bar.hbs
addon\templates\components\common\bs-progress\bar.hbs
addon\templates\components\common\bs-tooltip.hbs

I'd open a PR myself, pull a fork, etc., but, as you've already got a PR open adjusting for the recent raft of fresh deprecations, hopefully these will be easy. :)

Now if I could only figure out which upstream module was dropping the modifier-manager version stuff - so far I've got about 8 candidates to look at.

[simonihmig]

While you're at it, do you want to do all the {{#if hasBlock}} to {{#if has-block}} adjustments, with hasBlock also deprecated in beta?

This should have been addressed already be #1421! It's just not released yet.

[lupestro]

This should have been addressed already be #1421! It's just not released yet.

I just checked - #1421 is merged and didn't try to address this particular deprecation. hasBlock rather than has-block is present in handlebars in master, so no fix has been merged for it, and I didn't see another open PR to address them.

[simonihmig]

Oh, you are right. The PR did tackle a few, but apparently not all.

I do however wonder why you see deprecations for this? As any deprecations will fail CI, and beta is now passing again with this PR!

[simonihmig]

The remaining deprecation in Canary here comes from extending LinkComponent, which will be tackled by a separate PR. So going to merge this.

[simonihmig]

I'd open a PR myself

@lupestro If you have the time, this would be very welcome! 🙂

[lupestro]

I'll put it on my list for some evening this week. I'll do due diligence, but my contribution will want an attentive reviewer, as I build projects for my team that use ember-bootstrap but I haven't used it in my own work yet.