Add experimental/incomplete Bootstrap 5 support to existing components #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change *pretends* that BS5 components require the same markup as BS4. This should be true for many components, but not all. Follow up PRs will be created to address the later cases, see #1494. But at least this is better than what we had before, as the macros checks for only 4 or 5 would leave the markup for BS5 broken basically everywhere. And allows us to iterate step by step on fixing the remaining issues, with BS5 already enjoying full CI coverage.
|
I like the approach. Wondering if we should name it |
I like, updated it! CI seems to be green now finally (except for #1498) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change pretends that BS5 components require the same markup as BS4. This should be true for many components, but not all. Follow up PRs will be created to address the latter cases, see #1494.
But at least this is better than what we had before, as the macros checked for only 3 or 4 and would leave the markup for BS5 broken basically everywhere. And this allows us to iterate step by step on fixing the remaining issues, with BS5 already enjoying full CI coverage.
@jelhan This was mostly a find-and-replace job, so no line by line review required. But would like to hear if you approve this approach here!