Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove <BsForm::Group> component #1631

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Oct 20, 2021

This removes the <BsForm::Group> component, which was yielded as group from <BsForm>. It provided some value for Bootstrap 3. But due to some changes in Bootstrap 4 (and 5) markup related to form validation, it wasn't provided much value anymore for recent Bootstrap version.

Please see #1629 for more context.

Migration

Bootstrap 4

Before

<BsForm as |form|>
  <form.group>
    {{! some content }}
  </form.group>
</BsForm>

After

<BsForm>
  <div class="form-group">
    {{! some content }}
  </div> 
</BsForm>

If @formLayout is "horizontal", you need to add "row" class to <div class="form-group"> additionally.

Bootstrap 5

Before

<BsForm as |form|>
  <form.group>
    {{! some content }}
  </form.group>
</BsForm>

After

<BsForm>
  <div>
    {{! some content }}
  </div> 
</BsForm>

If @formLayout is "horizontal", you need to add "row" class to <div class="form-group"> additionally.

@simonihmig simonihmig changed the title remove <BsForm::Group> component remove <BsForm::Group> component Oct 21, 2021
Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simonihmig simonihmig merged commit 56edc48 into master Oct 21, 2021
@simonihmig simonihmig deleted the drop-bs-form-group-component branch October 21, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants