remove is-validating, is-required and is-disabled CSS classes from <BsForm::Element>
#1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
deleted the
drop-class-not-supported-by-bootstrap-from-form-element
branch
simonihmig
changed the title
<BsForm::Element>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the CSS class
.is-validating,.is-requiredand.is-disabledCSS classes. The CSS classes were applied to the<div>wrapper rendered by<BsForm::Element>in some cases. None of these classes is officially supported by Bootstrap..is-requiredand.is-disabledCSS class were only set if@requiredor@disabledargument was set. Both arguments were deprecated and officially removed in Boostrap 4. They weren't part of the public API anymore. Removing the CSS classes rendered by them should be considered clean-up and not a breaking change in my opinion..is-validatingCSS class was set while form element validation was pending. The class is not officially supported by Bootstrap. Removing it is a breaking change.There isn't an official migration path for applications depending on it. In case your application relied on any of them, please open an issue.
Closes #1261