Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal footer should not render a <form> element #1699

Merged
merged 1 commit into from
Nov 15, 2021
Merged

modal footer should not render a <form> element #1699

merged 1 commit into from
Nov 15, 2021

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Nov 15, 2021

Closes #1427

simonihmig
simonihmig approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I still wonder why we had that, probably some very old patterns of using a submit button in the footer. But as all tests are passing, we can happily get rid of this legacy cruft!

@simonihmig simonihmig merged commit e614689 into master Nov 15, 2021
@simonihmig simonihmig deleted the modal-footer-should-not-render-a-form branch November 15, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonihmig simonihmig simonihmig approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BsModalComponent renders footer as a form tag
2 participants
@jelhan @simonihmig