Form: click on input group button should not show validations #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
reviewed
Jan 3, 2019
Before this change a click on an input group button triggered validation to be shown by default if bubbling of focus out event was not prevented.
jelhan
force-pushed
the
fix-validation-should-not-be-shown-after-click-on-input-group-button
branch
from
74bd13d
to
4ef8d38
Compare
simonihmig
reviewed
Jan 3, 2019
jelhan
commented
Jan 6, 2019
| isArray(this.get('doNotShowValidationForEventTargets')) && | ||
| this.get('doNotShowValidationForEventTargets.length') > 0 && | ||
| [...this.element.querySelectorAll(this.get('doNotShowValidationForEventTargets').join(','))] | ||
| .some((el) => el.contains(target)) |
There was a problem hiding this comment.
An element contains itself. A little bit confusing but therefore we don't need to check el === target.
simonihmig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change a click on an input group button triggered validation to be shown by default if bubbling of focus out event was not prevented.