Assertion to prevent setting both property and value on a form element #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fails cause of a deprecation triggered in ember beta by carousel:
Not related to this PR at all. |
simonihmig
reviewed
Apr 18, 2019
Co-Authored-By: rrglomsk <rrglomsk@users.noreply.github.com>
simonihmig
approved these changes
Apr 22, 2019
|
Thanks again! |
|
No problem 😄!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation does mention that the element's value will be bound if you use the
propertyproperty, but we wound up with a few strayvalueproperties set along withpropertyon form elements in our application which lead to some unexpected bugs cropping up in production. It seems like a mistake that's not too difficult to make, so just an extra safety measure :)!