Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress bar role and ARIA attributes #983

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Fix progress bar role and ARIA attributes #983

merged 1 commit into from
Feb 2, 2020

Conversation

simonihmig
Copy link
Contributor

No description provided.

jelhan
jelhan approved these changes Feb 2, 2020
View reviewed changes
Copy link
Contributor

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The changes to angle bracket component invocation in the tests aren't related to the bug, are they? Curly component invocation will still be fully supported, isn't it? Just want to make sure that I didn't missed something.

@simonihmig
Copy link
Contributor Author

The changes to angle bracket component invocation in the tests aren't related to the bug, are they?

No, no changes there. I just copied the test with the newly added assertions from the other branch (#982), which already had ABI in that test...

@simonihmig simonihmig merged commit fd3a1cb into master Feb 2, 2020
@simonihmig simonihmig deleted the fix-aria-progress branch February 2, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelhan jelhan jelhan approved these changes

Assignees
No one assigned
Labels
a11y bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonihmig @jelhan