Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-entry): Enable preview of entry without mobile flavors #278

Merged
merged 1 commit into from
Dec 3, 2017

Conversation

amirch1
Copy link
Collaborator

@amirch1 amirch1 commented Nov 27, 2017

…simulation mode in player V2

PR information

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • [] Feature
  • [] Code style update (formatting, local variables)
  • [] Refactoring (no functional changes, no api changes)
  • [] Build related changes
  • [] CI related changes
  • [] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Entries without mobile flavors are not playable in Entry details preview player

What is the new behavior?
Entries without mobile flavors are playable in Entry details preview player

Does this PR introduce a breaking change? (check one with "x")

  • [] Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...


Other information

Where should the reviewer start?
Entry details preview

How should this be manually tested?
Delete all mobile flavors and preview the entry

Any background context you want to provide?


This change is Reviewable

@amirch1 amirch1 requested a review from esakal November 30, 2017 09:13
@esakal
Copy link
Collaborator

esakal commented Dec 3, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@esakal esakal merged commit 1b2fa41 into master Dec 3, 2017
@esakal esakal deleted the KMCNG-661 branch December 3, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants