Avoid marking the same type as used twice (#308)

Fixes #305
graphql-hive · Aug 23, 2022 · 5a212f6 · 5a212f6
1 parent 5761d9e
commit 5a212f6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/.changeset/shiny-rats-rule.md b/.changeset/shiny-rats-rule.md
@@ -0,0 +1,5 @@
+---
+'@graphql-hive/client': patch
+---
+
+Avoid marking the same type as used twice
diff --git a/packages/libraries/client/src/internal/usage.ts b/packages/libraries/client/src/internal/usage.ts
@@ -195,6 +195,7 @@ export function createCollector({ schema, max, ttl }: { schema: GraphQLSchema; m
 
   function collect(doc: DocumentNode): CacheResult {
     const entries = new Set<string>();
+    const collected_entire_named_types = new Set<string>();
 
     function markAsUsed(id: string) {
       if (!entries.has(id)) {
@@ -244,6 +245,15 @@ export function createCollector({ schema, max, ttl }: { schema: GraphQLSchema; m
     function markEntireTypeAsUsed(type: GraphQLInputType): void {
       const namedType = unwrapType(type);
 
+      if (collected_entire_named_types.has(namedType.name)) {
+        // No need to mark this type as used again
+        return;
+      } else {
+        // Add this type to the set of types that have been marked as used
+        // to avoid infinite loops
+        collected_entire_named_types.add(namedType.name);
+      }
+
       if (isScalarType(namedType)) {
         markAsUsed(makeId(namedType.name));
         return;