Fix createServicesFetcher handle null service url (#563)

graphql-hive · Oct 31, 2022 · d58a470 · d58a470
1 parent c47df83
commit d58a470
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/.changeset/famous-readers-cheat.md b/.changeset/famous-readers-cheat.md
@@ -0,0 +1,5 @@
+---
+'@graphql-hive/client': minor
+---
+
+Fix createServicesFetcher handling null service url
diff --git a/packages/libraries/client/src/gateways.ts b/packages/libraries/client/src/gateways.ts
@@ -4,7 +4,7 @@ import type { SchemaFetcherOptions, ServicesFetcherOptions } from './internal/ty
 
 interface Schema {
   sdl: string;
-  url: string;
+  url: string | null;
   name: string;
 }
 
@@ -62,7 +62,11 @@ export function createSchemaFetcher({ endpoint, key }: SchemaFetcherOptions) {
 
   return function schemaFetcher() {
     return fetcher().then(schema => ({
-      id: createHash('sha256').update(schema.sdl).update(schema.url).update(schema.name).digest('base64'),
+      id: createHash('sha256')
+        .update(schema.sdl)
+        .update(schema.url || '')
+        .update(schema.name)
+        .digest('base64'),
       ...schema,
     }));
   };
@@ -74,7 +78,11 @@ export function createServicesFetcher({ endpoint, key }: ServicesFetcherOptions)
   return function schemaFetcher() {
     return fetcher().then(services =>
       services.map(service => ({
-        id: createHash('sha256').update(service.sdl).update(service.url).update(service.name).digest('base64'),
+        id: createHash('sha256')
+          .update(service.sdl)
+          .update(service.url || '')
+          .update(service.name)
+          .digest('base64'),
         ...service,
       }))
     );