fix: skip visiting directive arguments when collecting usage #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 42b662b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kamilkisiela
force-pushed
the
argument-directive-bug
branch
from
93437e9 to
42b662b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
fixes #1220
GraphQL visitor
typeInfo.getFieldDef()yieldsundefinedwhen visiting arguments of a directive applied to a fragment spread within a fragment.Description
When visiting a GraphQL operation, skip visiting the arguments of a directive - there is no value in visiting directive arguments (or even directives in general) in the context of determining field usage
Client side GraphQL directives on query documents don't affect the actual field usage of a schema. i.e. it wouldn't matter if
@skipor@includeexclude a field for a particular operation - the execution of a query would fail if the schema didn't have the fields in the first place.Checklist