Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apollo Client directives in hive operations:check #3543

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

kamilkisiela
Copy link
Contributor

As we don't want to allow users to pass JSON object with GraphQL Inspector specific configuration (version of @graphql-inspector/core may change over time and it could lead to breaking changes at Hive CLI level), we prefer to control the available flags and support them long term by moving some logic into Hive CLI.
This way we are aware of the actual usage of these flags and can predict/prevent breaking change.

Closes #3356

Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: 35944c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-hive/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 7, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/cli 0.33.0-alpha-20231207115241-35944c4f1a285fd052ab84fa44abd116304ce7f2 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Dec 7, 2023

🐋 This PR was built and pushed to the following Docker images (tag: 35944c4f1a285fd052ab84fa44abd116304ce7f2):

Docker Bake metadata
{
"app": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:af0e48145d10d62fc79896e84855efceb4fa1f89140befcb4e2f54b059f3dd6e",
    "size": 685
  },
  "containerimage.digest": "sha256:af0e48145d10d62fc79896e84855efceb4fa1f89140befcb4e2f54b059f3dd6e",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/app:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/app:kamil_cli_apollo_client_support"
},
"composition-federation-2": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:e5bd048803f5d146b6ff75f5b2f834e9b1ca77fdd1afee11e8883d809c7e7428",
    "size": 685
  },
  "containerimage.digest": "sha256:e5bd048803f5d146b6ff75f5b2f834e9b1ca77fdd1afee11e8883d809c7e7428",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:kamil_cli_apollo_client_support"
},
"emails": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:abe859fad847962bb8a47f035e5ac384087a1ab091cfcb4f3584890428b71ae2",
    "size": 685
  },
  "containerimage.digest": "sha256:abe859fad847962bb8a47f035e5ac384087a1ab091cfcb4f3584890428b71ae2",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/emails:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/emails:kamil_cli_apollo_client_support"
},
"policy": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:79bab3e1316898ba31f5b57a486b8d4332c5bf556f8deb75b5674df05cfc29cf",
    "size": 685
  },
  "containerimage.digest": "sha256:79bab3e1316898ba31f5b57a486b8d4332c5bf556f8deb75b5674df05cfc29cf",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/policy:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/policy:kamil_cli_apollo_client_support"
},
"rate-limit": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:f8d85778ec4e1d95f2adb352adddb89dbbe107ec8f5877a4a77966d058382f8f",
    "size": 685
  },
  "containerimage.digest": "sha256:f8d85778ec4e1d95f2adb352adddb89dbbe107ec8f5877a4a77966d058382f8f",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/rate-limit:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/rate-limit:kamil_cli_apollo_client_support"
},
"schema": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:ccc95d14f046b777c9438635991fba8c750f6c9834d2f28a920c008f0edca135",
    "size": 685
  },
  "containerimage.digest": "sha256:ccc95d14f046b777c9438635991fba8c750f6c9834d2f28a920c008f0edca135",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/schema:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/schema:kamil_cli_apollo_client_support"
},
"server": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:ee10abbd1641a61972d44db218ea2f5d451a48d51799235f04a4bc913323e33f",
    "size": 685
  },
  "containerimage.digest": "sha256:ee10abbd1641a61972d44db218ea2f5d451a48d51799235f04a4bc913323e33f",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/server:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/server:kamil_cli_apollo_client_support"
},
"storage": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:e63d80189478a43ac71e2f1a570bfb14bddd5a9180378277d38dd986af9103ed",
    "size": 685
  },
  "containerimage.digest": "sha256:e63d80189478a43ac71e2f1a570bfb14bddd5a9180378277d38dd986af9103ed",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/storage:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/storage:kamil_cli_apollo_client_support"
},
"stripe-billing": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:6369240cbc8cf5c2ff4e03545799c00c77b47b089c08b9f12a68c292d002dd5f",
    "size": 685
  },
  "containerimage.digest": "sha256:6369240cbc8cf5c2ff4e03545799c00c77b47b089c08b9f12a68c292d002dd5f",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/stripe-billing:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/stripe-billing:kamil_cli_apollo_client_support"
},
"tokens": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:f7a77540f499ae9d3f7f51e57e0a7b5c1d3c6eccb2b91e51b486aa42f9c1b151",
    "size": 685
  },
  "containerimage.digest": "sha256:f7a77540f499ae9d3f7f51e57e0a7b5c1d3c6eccb2b91e51b486aa42f9c1b151",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/tokens:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/tokens:kamil_cli_apollo_client_support"
},
"usage": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:8503e2449d0108d59a59471734c7896caf45c7ea96c703f377cfd34ec70318c2",
    "size": 685
  },
  "containerimage.digest": "sha256:8503e2449d0108d59a59471734c7896caf45c7ea96c703f377cfd34ec70318c2",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/usage:kamil_cli_apollo_client_support"
},
"usage-estimator": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:948e93fadbce0381014b61b377e15fbc4f401e642b12dd6a1d8180adcabd5a6c",
    "size": 685
  },
  "containerimage.digest": "sha256:948e93fadbce0381014b61b377e15fbc4f401e642b12dd6a1d8180adcabd5a6c",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-estimator:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/usage-estimator:kamil_cli_apollo_client_support"
},
"usage-ingestor": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:2b64f8b9ed239736f1cdb61ddbf2643d4c95ba29d498a3ac69fdb3012e96fedf",
    "size": 685
  },
  "containerimage.digest": "sha256:2b64f8b9ed239736f1cdb61ddbf2643d4c95ba29d498a3ac69fdb3012e96fedf",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:kamil_cli_apollo_client_support"
},
"webhooks": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:30843b5523cacf19a7d2092cf1295b14a3ecdebf8bfc00920b71c8322e075ee9",
    "size": 685
  },
  "containerimage.digest": "sha256:30843b5523cacf19a7d2092cf1295b14a3ecdebf8bfc00920b71c8322e075ee9",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/webhooks:35944c4f1a285fd052ab84fa44abd116304ce7f2,ghcr.io/kamilkisiela/graphql-hive/webhooks:kamil_cli_apollo_client_support"
}
}

@kamilkisiela kamilkisiela force-pushed the kamil-cli-apollo-client-support branch from 26a0c4e to 35944c4 Compare December 7, 2023 11:51
@kamilkisiela kamilkisiela merged commit 6895ee3 into main Dec 11, 2023
25 checks passed
@kamilkisiela kamilkisiela deleted the kamil-cli-apollo-client-support branch December 11, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant