Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self-hosting options to GraphQL Hive client #499

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

kamilkisiela
Copy link
Contributor

@kamilkisiela kamilkisiela commented Oct 17, 2022

 {
   usage: {
-    endpoint: 'https://api.com/usage'
   },
   reporting: {
-    endpoint: 'https://api.com/graphql'
   },
+  selfHosting: {
+    graphqlEndpoint: 'https://api.com/graphql',
+    applicationUrl: 'https://app.com',
+    usageEndpoint: 'https://api.com/usage',
+  }
}

This way everything that's related to GraphQL Hive Cloud can be replaced, the links, the endpoints, token info, everything.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: 79f82ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-hive/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

agent: {
logger,
},
token: 'Token',

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Token" is used as [authorization header](1). The hard-coded value "Token" is used as [authorization header](2).
info: jest.fn(),
};

const token = 'Token';

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Token" is used as [authorization header](1). The hard-coded value "Token" is used as [authorization header](2).
Copy link

@danielfigueiredo danielfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/libraries/client/README.md Show resolved Hide resolved
packages/libraries/client/README.md Show resolved Hide resolved
@kamilkisiela kamilkisiela force-pushed the kamil-self-hosting-client branch from 0f0828c to 79f82ba Compare October 17, 2022 18:25
@kamilkisiela kamilkisiela enabled auto-merge (squash) October 17, 2022 18:25
@kamilkisiela kamilkisiela merged commit 682cde8 into main Oct 18, 2022
@kamilkisiela kamilkisiela deleted the kamil-self-hosting-client branch October 18, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants