Fix createServicesFetcher handle null service url #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dae8cf8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
PabloSzx
commented
Oct 30, 2022
PabloSzx
commented
Oct 30, 2022
| @@ -4,7 +4,7 @@ import type { SchemaFetcherOptions, ServicesFetcherOptions } from './internal/ty | |||
|
|
|||
| interface Schema { | |||
| sdl: string; | |||
| url: string; | |||
| url: string | null; | |||
There was a problem hiding this comment.
this change is actually breaking since it's also used as return type
dotansimha
approved these changes
Oct 30, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that when a service doesn't set an explicit service URL, which seems to be valid state, the fetcher fails when it tries to create the hash since you can't give
nullinto a Node.js crypto hashscreenshot of reference:
cc @saihaj @kamilkisiela