Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen redraw after closing an outside window #37

Closed
muralikodali opened this issue Dec 27, 2020 · 7 comments
Closed

screen redraw after closing an outside window #37

muralikodali opened this issue Dec 27, 2020 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@muralikodali
Copy link

I am using i3 window manager. After opening a file or image from joshuto and closing afterwards, screen display is not redrawn as shown below.

screenshot_20201227143114

@kamiyaa kamiyaa added enhancement New feature or request help wanted Extra attention is needed labels Dec 27, 2020
@kamiyaa
Copy link
Owner

kamiyaa commented Dec 27, 2020

Yes, this is a bug that I am aware of.
The current solution is to:

  1. resize terminal
  2. input some keys (which will trigger a redraw)
  3. resize the terminal back
  4. input more keys (which will trigger another redraw).

I'm not exactly sure how to implement this currently.
One thing that could be done is using events() instead of keys().
This should give a wider range of input types, not just keystrokes.

But this is currently not of high priority to me, so it might take a while for me to get back to this.

@kamiyaa
Copy link
Owner

kamiyaa commented Dec 30, 2020

Should be implemented in e4faa16

@kamiyaa
Copy link
Owner

kamiyaa commented Dec 30, 2020

Feel free to re-open issue if still not working

@kamiyaa kamiyaa closed this as completed Dec 30, 2020
@goderich
Copy link

I'm using version 0.9.0 from Archlinux's AUR (joshuto-git), and still encountering this issue with a tiling window manager.

@kamiyaa
Copy link
Owner

kamiyaa commented May 31, 2021

I'm using version 0.9.0 from Archlinux's AUR (joshuto-git), and still encountering this issue with a tiling window manager.

Could you provide some more information and potentially a screenshot?
ie. before, after screenshots, what program/terminal/wm you were using, etc.

Thanks

@goderich
Copy link

goderich commented Jun 1, 2021

Hi @kamiyaa , thanks for replying so quickly!

I am using bspwm as my WM, and alacritty as my terminal. Usually I run tmux too, but I tried joshuto in both, with the same results.
I don't know how to paste screenshots here (I don't think bspwm or any of my file managers do drag-and-drop), so here's an imgur link with the glitch in alacritty with and without tmux: https://imgur.com/a/SsosOvv

Please let me know what else I can do to help you help me.

@goderich
Copy link

goderich commented Jun 2, 2021

OK, so I just upgraded my system and I don't seem to be experiencing it anymore (joshuto was not updated, mind). I don't know what happened. I'll keep you posted if this reappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants