Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read and tail take different kinds of callbacks #3

Open
pvh opened this issue May 17, 2019 · 1 comment
Open

read and tail take different kinds of callbacks #3

pvh opened this issue May 17, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pvh
Copy link

pvh commented May 17, 2019

Not sure why tail() doesn't have an err callback but it was a bit surprising.

@hackergrrl
Copy link
Member

I agree. tail and onInsert could be emitted events instead:

view.events.on('insert', (msg) => {})

view.events.on('tail', (msg) => {})

view.events.on('error', (err) => {})

@hackergrrl hackergrrl added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants