Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsers are merged not overridden #94

Closed
pflannery opened this issue Mar 5, 2014 · 1 comment
Closed

Browsers are merged not overridden #94

pflannery opened this issue Mar 5, 2014 · 1 comment

Comments

@pflannery
Copy link

In the documentation here it says that we can override the browsers array with different browser specs but I've found that it's only merging them.

So if I have

karma: {
  options: {
    runnerPort: 9999,
    browsers: ['Chrome', 'Firefox']
  },
  continuous: {
    singleRun: true,
    browsers: ['PhantomJS']
  }
}

and I run grunt karma:continuous I end up with

['PhantomJS', 'Firefox']

Only browsers[0] from continuous gets overridden but browsers[1] from options is left intact.

Can I suggest changing this line here to:

data = _.merge(options, data)
data.browsers = this.data.browsers;

I can PR if there isn't something I'm missing?

@pflannery
Copy link
Author

@dignifiedquire great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant