-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(launcher): output stderr for failing launchers
- Loading branch information
Showing
4 changed files
with
33 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
Feature: Launcher error | ||
In order to use Karma | ||
As a person who wants to write great tests | ||
I want Karma to output stderr if a browser fails to connect. | ||
|
||
Scenario: Broken Browser | ||
Given a configuration with: | ||
""" | ||
files = ['launcher-error/specs.js']; | ||
browsers = [__dirname + '/launcher-error/fake-browser.sh']; | ||
plugins = [ | ||
'karma-jasmine', | ||
'karma-script-launcher' | ||
]; | ||
""" | ||
When I run Karma | ||
Then it fails with like: | ||
""" | ||
Missing fake dependency | ||
""" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/bash | ||
|
||
echo "Missing fake dependency" 1>&2 | ||
exit 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
describe('something', function () { | ||
This comment has been minimized.
Sorry, something went wrong. |
||
it('should never happen anyway', function () { | ||
expect(true).toBe(true) | ||
}) | ||
}) |
Surprised this made it through. I happen to be trying to figure out why karma + my launcher isn't working after I update karma to a later version.