Sourcemap regex, not working in windows

[chandru9279]

I'm using karma-bro.

Im getting callstacks

ReferenceError: Can't find variable: CustomVar at http://localhost:9000/absoluteC:/Users/Zasz/AppData/Local/Temp/a08f24cea0a6c2e347f78175362d890cf06e8561.browserify?da39a3ee5e6b4b0d3255bfef95601890afd80709:247"

I can see that you are using the regex to rewrite callstacks:

 /http:\/\/[^\/]*\/(base|absolute)([^\?\s\:]*)(\?\w*)?(\:(\d+))?(\:(\d+))?/g

The regex fails - the path, line and column not detected properly on my machine - so I don't get sourcemap replacement in my callstack.

Here is a test case, you can run this in browser for quick check :

var b =  function(_, prefix, path, __, ___, line, ____, column) {
 console.log("Prefix " + prefix)
 console.log("Path " + path)
 console.log("Line " + line)
 console.log("Col " + column)
 };

 var a = "ReferenceError: Can't find variable: Customvar at http://localhost:9000/absoluteC:/Users/Zasz/AppData/Local/Temp/a08f24cea0a6c2e347f78175362d890cf06e8561.browserify?da39a3ee5e6b4b0d3255bfef95601890afd80709:247";


 var URL_REGEXP = new RegExp('http:\\/\\/[^\\/]*\\/' +
                              '(base|absolute)' + // prefix
                              '([^\\?\\s\\:]*)' + // path
                              '(\\?\\w*)?' +      // sha
                              '(\\:(\\d+))?' +    // line
                              '(\\:(\\d+))?' +    // column
                              '', 'g');

a.replace(URL_REGEXP, b);

[chandru9279]

If I remove the \\: from the path '([^\\?\\s\\:]*)' + // path it seems to work, any context on why we are looking for "Not colon" to get path? Isn't "Not Questionmark, and not whitespace" enough?

d7c31f9

[maksimr]

@chandru9279 no because url may not contain sha but contain line and column

[maksimr]

@chandru9279 fix from PR should fix it

[chandru9279]

Thanks!