Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Karma 1.7.1 with Node 8 support #2818

Closed
alecf opened this issue Aug 22, 2017 · 10 comments
Closed

Release Karma 1.7.1 with Node 8 support #2818

alecf opened this issue Aug 22, 2017 · 10 comments

Comments

@alecf
Copy link

alecf commented Aug 22, 2017

Now that #2754 is fixed, someone needs to release a new version of karma that has node 8 support specified.

@cletusw
Copy link

cletusw commented Aug 29, 2017

@dignifiedquire Can we get this release for Node 8 support? Thanks.

@dignifiedquire
Copy link
Member

we currently have some breaking changes on master which will require some careful testing before I can release them, which I didn't found time for yet sorry

@cletusw
Copy link

cletusw commented Aug 29, 2017

Okay.

@cletusw
Copy link

cletusw commented Aug 29, 2017

@dignifiedquire Would you accept a branch with just 1.7.0 and the node 8 commit? That way it could just be released as 1.7.1 without the changes in master.

@cletusw
Copy link

cletusw commented Aug 29, 2017

@dignifiedquire In case you agree, I've created a 1.x branch on my fork that is simply 1.7.0 plus the node 8 change. If you'd like, you can create that branch in the main repo, run npm version patch, update the changelog, and use npm publish to publish that branch as 1.7.1

https://github.com/cletusw/karma/tree/1.x

@dignifiedquire
Copy link
Member

Thanks @cletusw that is probably something we can do. I will check it out later today.

@nicksrandall
Copy link

@cletusw, you're always one step ahead of me.

@cletusw
Copy link

cletusw commented Aug 29, 2017

@nicksrandall Lol. As a workaround, you can npm install --force karma and then npm install.

@dignifiedquire
Copy link
Member

Published from https://github.com/karma-runner/karma/tree/1.7.1 which includes only that change

@cletusw
Copy link

cletusw commented Aug 30, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants