Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): update bundleResource test timeout #3038

Merged
merged 1 commit into from
Jun 11, 2018
Merged

fix(test): update bundleResource test timeout #3038

merged 1 commit into from
Jun 11, 2018

Conversation

lusarz
Copy link
Contributor

@lusarz lusarz commented Jun 9, 2018

No description provided.

@@ -16,7 +16,7 @@ describe('BundleUtils.bundleResource', () => {
expect(fs.existsSync(PathUtils.calculateAbsolutePath('test/unit/fixtures/bundled.js'))).to.be.true
done()
})
})
}).timeout(5000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this.timeout(5000) in the function body (we have 2 other examples like that). I think that form is clearer to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, for me it(...).timeout(5000) is more readable because allows to separate from test content and test configuration. We are also able to use arrow function in that case.

What about changing other places into that style ?

Although it's detail, so I'm okay with this.timeout() as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok the arrow function argument convinced me ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants