feat(server): allow 'exit' listeners to set exit code #3541
Conversation
|
✅ Build karma 2716 completed (commit dcd8f32ae6 by @matz3) |
|
❌ Build karma 317 failed (commit dcd8f32ae6 by @matz3) |
|
✅ Build karma 318 completed (commit a328c65e2a by @matz3) |
|
❌ Build karma 319 failed (commit 27a7cc0b3f by @matz3) |
|
❌ Build karma 318 failed (commit a4c1ebae71 by @matz3) |
|
❌ Build karma 2717 failed (commit 27a7cc0b3f by @matz3) |
matz3
force-pushed
the
feat-server-exit-listener-set-exit-code
branch
from
05c8fc7
to
5a2e2f0
Compare
|
Rebased on top of latest master |
|
❌ Build karma 322 failed (commit bfe6a3e7c5 by @matz3) |
|
✅ Build karma 2720 completed (commit bfe6a3e7c5 by @matz3) |
|
❌ Build karma 321 failed (commit bfe6a3e7c5 by @matz3) |
|
Tests environment on Node 14 seems to be broken. At least I can't see any details about failing tests. |
|
Looks like a flake to me, can you try to close and re-open the PR to trigger a new build? |
|
❌ Build karma 2721 failed (commit 14a3cf4429 by @matz3) |
|
❌ Build karma 322 failed (commit 14a3cf4429 by @matz3) |
|
❌ Build karma 323 failed (commit 14a3cf4429 by @matz3) |
|
Done. Still failing. |
|
I see, probably something is off with AppVeyor as it fails on |
|
retry |
|
❌ Build karma 328 failed (commit be98c48cf4 by @matz3) |
|
❌ Build karma 2726 failed (commit be98c48cf4 by @matz3) |
|
@johnjbarton Check out #3544 for the workaround. |
|
❌ Build karma 327 failed (commit be98c48cf4 by @matz3) |
|
and again |
|
✅ Build karma 2728 completed (commit a0b96ad9c1 by @matz3) |
|
✅ Build karma 330 completed (commit a0b96ad9c1 by @matz3) |
|
✅ Build karma 329 completed (commit a0b96ad9c1 by @matz3) |
Currently it seems that it's not possible for reporters to set the exit code asynchronously. Within the "onRunComplete" event, the results.exitCode must be modified synchronously, otherwise the updated value is not taken into account. With this change, the reporters (or any other plugin) can pass an exit code to the callback of the 'exit' event.
matz3
force-pushed
the
feat-server-exit-listener-set-exit-code
branch
from
5a2e2f0
to
b7f7dea
Compare
|
I've rebased onto the latest master, squashed the two commits and dropped the |
|
✅ Build karma 2737 completed (commit e1234ad9c2 by @matz3) |
|
✅ Build karma 339 completed (commit e1234ad9c2 by @matz3) |
|
✅ Build karma 338 completed (commit e1234ad9c2 by @matz3) |
|
Any plans for a next release? |
# [5.2.0](v5.1.1...v5.2.0) (2020-08-31) ### Bug Fixes * **client:** avoid race between execute and clearContext ([#3452](#3452)) ([8bc5b46](8bc5b46)), closes [#3424](#3424) * **client:** check in bundled client code into version control ([#3524](#3524)) ([6cd5a3b](6cd5a3b)), closes [/github.com/karma-runner/karma/commit/f5521df7df5cd1201b5dce28dc4e326b1ffc41fd#commitcomment-38967493](https://github.com//github.com/karma-runner/karma/commit/f5521df7df5cd1201b5dce28dc4e326b1ffc41fd/issues/commitcomment-38967493) * **dependencies:** update dependencies ([#3543](#3543)) ([5db46b7](5db46b7)) * **docs:** Update 03-how-it-works.md ([#3539](#3539)) ([e7cf7b1](e7cf7b1)) * **server:** log error when file loading or preprocessing fails ([#3540](#3540)) ([fc2fd61](fc2fd61)) ### Features * **server:** allow 'exit' listeners to set exit code ([#3541](#3541)) ([7a94d33](7a94d33))
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
) Currently it seems that it's not possible for reporters to set the exit code asynchronously. Within the "onRunComplete" event, the results.exitCode must be modified synchronously, otherwise the updated value is not taken into account. With this change, the reporters (or any other plugin) can pass an exit code to the callback of the 'exit' event.
# [5.2.0](karma-runner/karma@v5.1.1...v5.2.0) (2020-08-31) ### Bug Fixes * **client:** avoid race between execute and clearContext ([karma-runner#3452](karma-runner#3452)) ([8bc5b46](karma-runner@8bc5b46)), closes [karma-runner#3424](karma-runner#3424) * **client:** check in bundled client code into version control ([karma-runner#3524](karma-runner#3524)) ([6cd5a3b](karma-runner@6cd5a3b)), closes [/github.com/karma-runner/karma/commit/f5521df7df5cd1201b5dce28dc4e326b1ffc41fd#commitcomment-38967493](https://github.com//github.com/karma-runner/karma/commit/f5521df7df5cd1201b5dce28dc4e326b1ffc41fd/issues/commitcomment-38967493) * **dependencies:** update dependencies ([karma-runner#3543](karma-runner#3543)) ([5db46b7](karma-runner@5db46b7)) * **docs:** Update 03-how-it-works.md ([karma-runner#3539](karma-runner#3539)) ([e7cf7b1](karma-runner@e7cf7b1)) * **server:** log error when file loading or preprocessing fails ([karma-runner#3540](karma-runner#3540)) ([fc2fd61](karma-runner@fc2fd61)) ### Features * **server:** allow 'exit' listeners to set exit code ([karma-runner#3541](karma-runner#3541)) ([7a94d33](karma-runner@7a94d33))
Currently it seems that it's not possible for reporters to set the exit code asynchronously.
Within the "onRunComplete" event, the
results.exitCodemust be modified synchronously, otherwise the updated value is not taken into account.With this change, the reporters (or any other plugin) can pass an exit code to the callback of the 'exit' event.
This is the only existing place I've found to be leveraged without creating a lot of new code and APIs.
Todos
chore(npm): update npmignore to allow install via GH urlcommit before mergeContext / background
This is currently a problem in the
karma-coverageplugin.See karma-runner/karma-coverage#418 and https://github.com/matz3/issue-karma-coverage-threshold-exit-code