-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): add support wildcard config for scoped package plugin #3659
feat(plugins): add support wildcard config for scoped package plugin #3659
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
✅ Build karma 539 completed (commit 632ce319f5 by @hdmr14) |
✅ Build karma 2936 completed (commit 632ce319f5 by @hdmr14) |
✅ Build karma 538 completed (commit 632ce319f5 by @hdmr14) |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @hdmr14!
It turned out that we didn't have any tests for this functionality, so I've implemented some in devoto13@ee942c5 (going to submit those as a separate PR once yours is merged).
What I found out is that flatMap
function is not available in Node 10, which Karma still supports. Can you please update your implementation to make sure that it supports Node 10 as well?
Besides this LGTM
✅ Build karma 2941 completed (commit 7e8c7cd539 by @hdmr14) |
✅ Build karma 544 completed (commit 7e8c7cd539 by @hdmr14) |
✅ Build karma 543 completed (commit 7e8c7cd539 by @hdmr14) |
@devoto13 Thanks for review and implement the tests! PR now supports Node 10(replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tests will be added in the follow-up PR: #3661
@googlebot I signed it! |
# [6.2.0](v6.1.2...v6.2.0) (2021-03-10) ### Features * **plugins:** add support wildcard config for scoped package plugin ([#3659](#3659)) ([39831b1](39831b1))
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…arma-runner#3659) * feat(plugins): add support wildcard config for scoped package plugin * fix(plugins): support Node 10
# [6.2.0](karma-runner/karma@v6.1.2...v6.2.0) (2021-03-10) ### Features * **plugins:** add support wildcard config for scoped package plugin ([karma-runner#3659](karma-runner#3659)) ([39831b1](karma-runner@39831b1))
If you wish load all scoped package plugins by
@*/karma-*
likekarma-*
, karma doesn't handle it.It'll be modified to
RegExp("^@.*/karma-*")
internally, and karma doesn't care scoped package's sub directories.In this PR, add features below.
*
(replace ALL*
to.*
)@*/karma-*
is now validkarma-*
also work same as before*
(such askarma-*-foo-.*
), there is a risk of incompatibility@foo
, now:@foo/bar
)Fixes #3656