-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excluding directories also excludes similarly-named files #5
Comments
Mind if I take this one? I see you have a branch with some refactorings. Not sure if you've tackled it there, but I've identified that it could be a problem with the logic in: It may be simpler to use the os.FileInfo that we have access to, to do directory Vs file comparison edge cases. Let me know if there are any other considerations that you've thought about! |
Very cool project btw! |
@jonesbrianc26 Go for it! Ended up moving the logic for this to So from what I can tell, the problem comes from my naive method of checking if the file path string contains the excluded directory, i.e. I haven't really given this much thought yet, but there might be a method to solve this with regular expressions. I look forward to seeing what you come up with! |
Resolved in #21! 😄 |
For example, excluding
.git
(with-.git
) results in.gitignore
not being listed.This can be resolved with excluding with
-.git/
instead, but then.git
is listed.The text was updated successfully, but these errors were encountered: