Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

CI: re-enable TODO/FIXME checker #469

Closed
jodh-intel opened this issue Jul 3, 2018 · 2 comments
Closed

CI: re-enable TODO/FIXME checker #469

jodh-intel opened this issue Jul 3, 2018 · 2 comments

Comments

@jodh-intel
Copy link
Contributor

Our CI tests have a check that will fail a PR if if changes any files that contain TODO or FIXME comments. We have this since such comments tends to never get fixed. As such, it is much better to have a reference to a github issue for the problem as that makes it visible.

The checker was added on PR #445 but had to be disabled with PR #464 as it was causing the CI builds to fail.

Once the following issues have been closed, this issue can be used to re-enable the TODO/FIXME checker:

@jodh-intel
Copy link
Contributor Author

When #471 lands, it will be possible to run just check TODO/FIXME checker on a repo like this:

$ export KATA_DEV_MODE=true
$ $GOPATH/src/github.com/kata-containers/tests/.ci/static-checks.sh --master --files --force

@jodh-intel
Copy link
Contributor Author

The command should (now) actually be:

$ $GOPATH/src/github.com/kata-containers/tests/.ci/static-checks.sh --files --force --all

(but blocked by #999).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant